Fix the AZs when creating subnets #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
reviewed
Sep 16, 2024
Comment on lines
+93
to
+100
| var subnetAzs []string | ||
| if opts.CapacityReservation { | ||
| subnetAzs, err = m.getAZsWithCapacity(opts) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| for _, az := range azs.AvailabilityZones { | ||
| if len(subnetAzs) == 2 { |
There was a problem hiding this comment.
could we have a panic if there is only 1 AZ with reserved capacity?
There was a problem hiding this comment.
We shouldn't, reserved capacity is usually associated with only one AZ.
There was a problem hiding this comment.
I'm ok with this approach, but it would be better if we just create subnets in All AZs and don't worry about reserved capacity's AZ.
Issacwww
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR addresses an issue with subnet creation by correcting the Availability Zones (AZs) used. Previously, subnets were created in the first two AZs of the region, which often led to failures due to mismatches with capacity reservations. This PR ensures that subnets are created in AZs that align with the specified capacity reservations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.