ci: fix integration-test-deployment script #35716
Open
+17
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admired-contributor
Abogical
force-pushed
the
integ-deployment-test-invoke-fix
branch
5 times, most recently
from
9eae906 to
933483c
Compare
- Previously, the script was executing the script under the cwd of the script package, when it should be at the head branch folder. We'll use node explicitly to run the script without changing the cwd. - Fixes the label and event conditions that would trigger the workflow. - Use STS to assume Atmosphere role as OIDC is not needed when we use the codebuild runner.
Abogical
force-pushed
the
integ-deployment-test-invoke-fix
branch
from
933483c to
bdc479e
Compare
PATH environment variable is used to find yarn/node binaries. Without it, a ENOENT error is emitted when running yarn.
Running via node directly instead of lerna will keep the cwd at the root as expected.
Abogical
force-pushed
the
integ-deployment-test-invoke-fix
branch
from
bdc479e to
5626551
Compare
Abogical
changed the title
Abogical
changed the title
aws-cdk-automation
added
the
pr/needs-maintainer-review
gasolima
reviewed
Oct 13, 2025
| fetch-depth: 0 | ||
| path: head | ||
|
|
||
| - name: Configure AWS credentials |
There was a problem hiding this comment.
Can we have the OIDC? Unless there's some concern on it that i'm not aware of
There was a problem hiding this comment.
OIDC added back in. I'm currently testing in my fork if it still works.
There was a problem hiding this comment.
It works with OIDC: https://github.com/Abogical/aws-cdk/actions/runs/18468338437/job/52623823984
gasolima
reviewed
Oct 13, 2025
| workflow_dispatch: {} | ||
| merge_group: {} | ||
| pull_request_target: | ||
| types: |
There was a problem hiding this comment.
What's the default behaviour if we didn't mention any?
There was a problem hiding this comment.
It won't listen to any labelling events by default. So if we add the pr/needs-integration-test-deployment label, the workflow will still be skipped.
gasolima
reviewed
Oct 13, 2025
| "bump": "./bump.sh", | ||
| "build-all": "tsc -b" | ||
| "build-all": "tsc -b", | ||
| "atmosphere-integ-test": "lerna run build --scope @aws-cdk/integration-test-deployment && node tools/@aws-cdk/integration-test-deployment/bin/index.js" |
There was a problem hiding this comment.
Why is it building? I believe the normal pattern here is another separate command building, then this one only running
There was a problem hiding this comment.
pkglintabove inpackage.jsonfollows the same pattern.- It'll be helpful as a developer to have one command to rebuild and test the script to allow for faster development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Description of changes
Describe any new or updated permissions being added
No new permissions were added.
Description of how you validated changes
Tested on my fork here: https://github.com/Abogical/aws-cdk/actions/runs/18465794651/job/52607352315?pr=15
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license