-
Notifications
You must be signed in to change notification settings - Fork 35
feat: refactor options can be provided via the config file #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
+ Coverage 79.38% 80.04% +0.65%
==========================================
Files 49 49
Lines 7209 7215 +6
Branches 809 817 +8
==========================================
+ Hits 5723 5775 +52
+ Misses 1467 1418 -49
- Partials 19 22 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two questions here:
- Can you give me an example of the use cases for this? I'm struggling to think why a user would choose to always run
cdk refactor
in dryrun mode. - This seems like a one-off solution for refactoring. Should we not build it in such a way that it works for all commands?
Yeah, you're right. I'll just close it and revisit this feature if someone asks for it. |
Pull request was closed
Allow the user to pass options via the config file:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license