feat(cli): user-provided cdk init templates #673
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohang9000
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iankhou
reviewed
Jun 30, 2025
custom-template-test3/README.md
Outdated
There was a problem hiding this comment.
Why 3? Let's have descriptive names if we're going to commit these template examples.
iankhou
reviewed
Jun 30, 2025
| return tempDir; | ||
| } catch (e) { | ||
| // Clean up on error | ||
| await fs.remove(tempDir).catch(() => { |
There was a problem hiding this comment.
Why empty catch block here?
iankhou
reviewed
Jun 30, 2025
init-fixed.ts
Outdated
|
|
||
| // Auto-detect language if not specified | ||
| if (!language && template.languages.length === 1) { | ||
| language = template.languages[0]; |
There was a problem hiding this comment.
I remember you mentioning we need to specify language, so autodetect can be removed?
iankhou
reviewed
Jun 30, 2025
template-name-summary.md
Outdated
| 3. Validate it contains required `typescript/` directory and `info.json` | ||
| 4. Use that specific template instead of root directory | ||
|
|
||
| ### 5. Error Handling |
There was a problem hiding this comment.
No need to specify here. How the error is handled should be evident to the user when they attempt to use the CLI.
rohang9000
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rohang9000
changed the title
rohang9000
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rohang9000
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rohang9000
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iliapolo
requested changes
Jul 21, 2025
| `No --language was provided, but '${type}' supports only '${language}', so defaulting to --language=${language}`, | ||
| try { | ||
| // BRANCH 1: Git Repository Template Source | ||
| if (options.gitUrl) { |
There was a problem hiding this comment.
The new options should be gated with the unstable feature protection. For example:
aws-cdk-cli/packages/aws-cdk/lib/cli/cli.ts
Lines 280 to 282 in 666f1b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated functionality allows CDK CLI users to pass in custom templates written in any CDK supported language from local directories, Git repositories, or NPM packages as parameters to the "cdk init" command.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license