Skip to content

improve logging #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

improve logging #1431

merged 1 commit into from
Jun 5, 2025

Conversation

sergiyvamz
Copy link
Contributor

@sergiyvamz sergiyvamz commented Jun 4, 2025

Summary

Improve logging

Additional Reviewers

@karenc-bq
@aaronchung-bitquill

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jun 4, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

LimitlessRouterServiceImpl.noRoutersAvailableForRetry=No transaction routers available for connection retry. Retrying with original connection.
LimitlessRouterServiceImpl.unableToConnectNoRoutersAvailable=Unable to connect to {0} when transaction routers are unavailable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of these messages, should we also include the suggestion like "Please verify authentication credentials, security groups, and network connectivity between the client and the Limitless Database cluster." ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"When" implies that the connection cannot happen because the transaction routers are unavailable. I don't think this is the case. "Unable to connect to {0}, transaction routers cannot be obtained."

If we wanted to add more debugging tips after, we can append it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@sergiyvamz sergiyvamz force-pushed the fix-limitless-original-exception branch from 4f558ac to b98dc8b Compare June 5, 2025 21:28
@sergiyvamz sergiyvamz enabled auto-merge (squash) June 5, 2025 21:31
@sergiyvamz sergiyvamz merged commit 3b84198 into main Jun 5, 2025
7 checks passed
@sergiyvamz sergiyvamz deleted the fix-limitless-original-exception branch June 5, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants