-
Notifications
You must be signed in to change notification settings - Fork 58
improve logging #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve logging #1431
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.1
with:
upload-result: true Contact Qodana teamContact us at qodana-support@jetbrains.com
|
LimitlessRouterServiceImpl.noRoutersAvailableForRetry=No transaction routers available for connection retry. Retrying with original connection. | ||
LimitlessRouterServiceImpl.unableToConnectNoRoutersAvailable=Unable to connect to {0} when transaction routers are unavailable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end of these messages, should we also include the suggestion like "Please verify authentication credentials, security groups, and network connectivity between the client and the Limitless Database cluster." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"When" implies that the connection cannot happen because the transaction routers are unavailable. I don't think this is the case. "Unable to connect to {0}, transaction routers cannot be obtained."
If we wanted to add more debugging tips after, we can append it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
4f558ac
to
b98dc8b
Compare
Summary
Improve logging
Additional Reviewers
@karenc-bq
@aaronchung-bitquill
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.