Skip to content

Support Security Group Name #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support Security Group Name #408

wants to merge 1 commit into from

Conversation

GnatorX
Copy link
Contributor

@GnatorX GnatorX commented Apr 17, 2024

  • sg name field in crd

  • add implementation

  • Move to getsgforVPC, move SG names into SG, unique items validation


Issue #, if available: #20

Description of changes:
Add support for Security group names
Continuation of #408

Credit: Most of the code was implemented by @abeer-stripe

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* sg name field in crd

* add implementation

* Move to getsgforVPC, move SG names into SG, unique items validation

---------

Co-authored-by: Garvin Pang <garvinp@stripe.com>
@GnatorX GnatorX closed this Apr 17, 2024
@GnatorX GnatorX reopened this Apr 17, 2024
@GnatorX GnatorX marked this pull request as ready for review April 17, 2024 16:52
@GnatorX GnatorX requested a review from a team as a code owner April 17, 2024 16:52
@sushrk
Copy link
Contributor

sushrk commented Apr 18, 2024

Thanks @GnatorX, I'm taking a look at the PR.

Few initial thoughts:
Can we merge this into a feature branch so I can work on testing this internally before release? I created a new branch sg-name.

expiration cache you linked earlier looks like a good start. We can check if CreateNetworkInterface fails due to missing security group and update the cache, and retry the branch ENI creation.

Can you also add integration tests? This can be in a follow up PR.

@GnatorX
Copy link
Contributor Author

GnatorX commented Apr 18, 2024

PR to merge into feature branch #410

@sushrk
Copy link
Contributor

sushrk commented Apr 18, 2024

Oh, it should be possible to just update the base branch in same PR, let me do that.

Edit: Cannot update it as there is already a new PR A pull request already exists for base branch 'sg-name' and head branch 'master-up'. We'll continue discussion on #410 , thanks.

@GnatorX
Copy link
Contributor Author

GnatorX commented Apr 19, 2024

Oh sorry. Didn't realize i could update it.

@sushrk
Copy link
Contributor

sushrk commented Apr 22, 2024

Closing in favor of #410

@sushrk sushrk closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants