Skip to content

chore(chat): make subcommands independent of commands #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Konippi
Copy link
Contributor

@Konippi Konippi commented May 13, 2025

Issue #, if available:
N/A
to ensure flexibility for feature functions (e.g., #1804)

Description of changes:
By separating subcommand from command,
this PR makes it possible to flexibly implement to future functions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Konippi Konippi force-pushed the make-subcommands-independent-of-commands branch from 253620f to 4956741 Compare May 14, 2025 13:18
@brandonskiser
Copy link
Contributor

Testing this and it doesn't seem to work - /profile h and pressing tab doesn't complete to the help subcommand, and instead does a fallback to the file system. Have you verified locally?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.75%. Comparing base (d4e9350) to head (2af5ee6).
Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1806   +/-   ##
=======================================
  Coverage   16.75%   16.75%           
=======================================
  Files         213      213           
  Lines       20704    20704           
  Branches      871      871           
=======================================
  Hits         3468     3468           
  Misses      17236    17236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Konippi
Copy link
Contributor Author

Konippi commented May 21, 2025

Testing this and it doesn't seem to work - /profile h and pressing tab doesn't complete to the help subcommand, and instead does a fallback to the file system. Have you verified locally?

I tried verifying it in my local environment.
I didn't implement subcommand completion because just refactoring for flexible code changes that would occur in the future. Probably the subcommand completion feature is not supported in the current version either...

@Konippi Konippi requested a review from a team as a code owner May 25, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants