feat(cli): infer pro license when identity provider and region are sp… #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This matches my expectation as a user. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
===========================================
+ Coverage 14.29% 16.75% +2.45%
===========================================
Files 2335 213 -2122
Lines 201929 20704 -181225
Branches 182293 871 -181422
===========================================
- Hits 28860 3468 -25392
+ Misses 171663 17236 -154427
+ Partials 1406 0 -1406 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Konippi
force-pushed
the
infer-pro-lisence-when-required-options-are-specified
branch
from
50a052d to
dd91be7
Compare
brandonskiser
approved these changes
May 1, 2025
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
resolve #1352
Description of changes:
This PR improves the user experience by automatically inferring Pro license when users provide both
--identity-providerand--regionparameters during login.I think --license is a necessary option regardless of pro/free.
Therefore, I thought it would be good to automatically determine that it is a pro license when --identity-provider and --region are specified.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.