Skip to content

fix: add flag for logging in with device flow on CLI, fix broken sigint handling during auth #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

brandonskiser
Copy link
Collaborator

@brandonskiser brandonskiser commented Apr 24, 2025

Description of changes:

  • Adding a flag to always use device code flow for q login. This is useful in cases where we think we can open a browser successfully, but are actually unable to handle redirects required for PKCE.
  • Fixing sigint handling to actually respect ctrl+c

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 14.34%. Comparing base (da59663) to head (a6ba825).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/q_cli/src/cli/user.rs 0.00% 12 Missing ⚠️
crates/q_cli/src/cli/installation.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   14.36%   14.34%   -0.02%     
==========================================
  Files        2368     2368              
  Lines      206348   206350       +2     
  Branches   186712   186714       +2     
==========================================
- Hits        29633    29605      -28     
- Misses     175257   175289      +32     
+ Partials     1458     1456       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonskiser brandonskiser marked this pull request as ready for review April 24, 2025 23:26
@brandonskiser brandonskiser requested a review from a team April 24, 2025 23:26
@brandonskiser brandonskiser enabled auto-merge (squash) April 25, 2025 20:04
@GoodluckH
Copy link
Collaborator

#1390

@brandonskiser brandonskiser merged commit 6c1fc3c into main Apr 28, 2025
21 checks passed
@brandonskiser brandonskiser deleted the bskiser/add-flag-for-device-code-auth branch April 28, 2025 22:06
This was referenced Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants