Skip to content

upgrade k8s dependencies to support DRA #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

upgrade k8s dependencies to support DRA #318

wants to merge 6 commits into from

Conversation

movence
Copy link
Contributor

@movence movence commented Jun 6, 2025

Issue #, if available:
DRA is not handled correctly https://kubernetes.io/docs/concepts/scheduling-eviction/dynamic-resource-allocation/. Operator is not able to handle the new spec due to the old k8s deps.

Description of changes:
Upgrade k8s.io and sigs.k8s.io dependency versions which also bump go version to 1.24 due to one of upgraded dep.

Test
Deploying the operator with changes then use https://github.com/NVIDIA/k8s-dra-driver-gpu/tree/main/deployments/helm/nvidia-dra-driver-gpu

helm install dra ./nvidia-dra-driver-gpu --create-namespace --namespace nvidia-dra --set resources.gpus.enabled=false
NAME: dra
LAST DEPLOYED: Fri Jun 20 02:17:42 2025
NAMESPACE: nvidia-dra
STATUS: deployed
REVISION: 1
TEST SUITE: None
➜  helm git:(main) ✗ kubectl apply -f test.yaml                                                                                           
namespace/gpu-test1 created
resourceclaimtemplate.resource.k8s.io/single-gpu created
pod/pod1 created
pod/pod2 created

TODOs
- Need any additional changes required
- PR checks are all passing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@movence movence marked this pull request as ready for review June 17, 2025 12:13
@sky333999 sky333999 changed the title upgrade k8s dependencies and go 1.24.0 to support DRA upgrade k8s dependencies to support DRA Jun 20, 2025
@@ -34,7 +34,7 @@ type WebhookHandler interface {
// the implementation.
type podMutationWebhook struct {
client client.Client
decoder *admission.Decoder
decoder admission.Decoder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it necessary to dereference here?

Copy link
Contributor

@Paramadon Paramadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants