Optimize dockerfile to prevent timeouts #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
force-pushed
the
tjstark/e2e-dockerfile-fix
branch
2 times, most recently
from
45224d1 to
069f198
Compare
Paramadon
reviewed
Apr 9, 2025
There was a problem hiding this comment.
could you link the e2e test here
There was a problem hiding this comment.
E2E test run that passed on MakeContainerImage step
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/14358637935
There was a problem hiding this comment.
Another successful E2E test run
musa-asad
previously approved these changes
Apr 10, 2025
TravisStark
changed the title
Adjusted build-and-upload step
TravisStark
force-pushed
the
tjstark/e2e-dockerfile-fix
branch
from
7b03dd7 to
f608fa2
Compare
lisguo
approved these changes
Apr 21, 2025
Paramadon
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding a retry to
go mod downloadin the dockerfile.This should help prevent flakiness in the MakeContainerImage step of the E2E tests
Increases timeout in test:
TestAlreadyAutoAnnotatedResourceShouldNotRestartBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.