Skip to content

Fix issue with e2e tests by updating dependencies in build-and-upload step #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

TravisStark
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@TravisStark TravisStark changed the title Fix issue with e2e tests by addin go mod tidy to build-and-upload step Fix issue with e2e tests by addon go mod tidy to build-and-upload step Apr 4, 2025
@TravisStark TravisStark force-pushed the tjstark/e2e-test-build branch from 7c6b998 to 95e6a8f Compare April 4, 2025 17:43
Paramadon
Paramadon previously approved these changes Apr 4, 2025
Copy link
Contributor

@Paramadon Paramadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like the go mod tidy worked nice!

varunch77
varunch77 previously approved these changes Apr 4, 2025
@TravisStark TravisStark changed the title Fix issue with e2e tests by addon go mod tidy to build-and-upload step Fix issue with e2e tests by by updating dependencies in build-and-upload step Apr 4, 2025
okankoAMZ
okankoAMZ previously approved these changes Apr 4, 2025
Copy link
Contributor

@okankoAMZ okankoAMZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got some unittest failing

@TravisStark TravisStark changed the title Fix issue with e2e tests by by updating dependencies in build-and-upload step Fix issue with e2e tests by updating dependencies in build-and-upload step Apr 4, 2025
@TravisStark TravisStark dismissed stale reviews from okankoAMZ, varunch77, and Paramadon via a4f73da April 4, 2025 18:32
@TravisStark TravisStark merged commit 5db734c into main Apr 8, 2025
16 of 19 checks passed
@TravisStark TravisStark deleted the tjstark/e2e-test-build branch April 8, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants