Skip to content

Implement Bypass Test Mechanism for Emergent Release #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 5, 2024
Merged

Conversation

musa-asad
Copy link
Contributor

@musa-asad musa-asad commented Dec 4, 2024

Description of the issue

When we release our operator and target allocator, we need to run the Build And Upload Artifact workflow in order to push the images to the release ECRs. However, sometimes we run into errors that block our release in our E2E tests that are expected to work.

We don't have a way to release when we have a test failure, which would be problematic under an emergent release.

Description of changes

  • Added e2e-test-bypass-link and e2e-test-bypass-approver inputs to provide the failing E2E test link and the person who will 2PR the bypass.
  • Added bypass-info job to display the e2e-test-bypass-link and e2e-test-bypass-approver inputs in the job summary.
  • Added conditional to the e2e-test job to only run if both e2e-test-bypass-link and e2e-test-bypass-approver are empty.

Testing

Ran the following workflow in two situations:

gh workflow run build-and-upload-release.yml \
  --ref bypass-e2e-test \
  --field e2e-test-bypass-link=https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/10255095727 \
  --field e2e-test-bypass-approver=musa-asad \
  --field release=false

Ran workflow: https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/12182695411
Screenshot 2024-12-05 at 11 51 17 AM


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@musa-asad musa-asad self-assigned this Dec 4, 2024
@musa-asad musa-asad requested review from movence and lisguo December 4, 2024 04:40
@musa-asad musa-asad marked this pull request as ready for review December 4, 2024 04:46
@musa-asad musa-asad requested a review from lisguo December 5, 2024 03:15
@lisguo lisguo merged commit 23146e7 into main Dec 5, 2024
14 checks passed
@lisguo lisguo deleted the bypass-e2e-test branch December 5, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants