Adding branch option to operator build workflow. #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
reviewed
Nov 8, 2024
musa-asad
reviewed
Nov 8, 2024
musa-asad
reviewed
Nov 8, 2024
musa-asad
previously approved these changes
Nov 8, 2024
musa-asad
previously approved these changes
Nov 8, 2024
jefchien
reviewed
Nov 11, 2024
lisguo
previously approved these changes
Nov 12, 2024
dricross
previously approved these changes
Nov 12, 2024
lisguo
reviewed
Nov 12, 2024
lisguo
previously approved these changes
Nov 12, 2024
Co-authored-by: Lisa Guo <lguo25@gmail.com>
musa-asad
requested changes
Dec 1, 2024
okankoAMZ
force-pushed
the
e2e-testing
branch
from
f3f43a7 to
baf4aec
Compare
musa-asad
requested changes
Dec 5, 2024
musa-asad
requested changes
Dec 5, 2024
musa-asad
reviewed
Dec 9, 2024
musa-asad
reviewed
Dec 9, 2024
musa-asad
reviewed
Dec 9, 2024
Co-authored-by: Musa <musaasad@amazon.com>
Co-authored-by: Musa <musaasad@amazon.com>
Co-authored-by: Musa <musaasad@amazon.com>
Co-authored-by: Musa <musaasad@amazon.com>
Co-authored-by: Musa <musaasad@amazon.com>
varunch77
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
1 ) Currently, operator determine what branch to build on using
github.shaandgithub.repohowever, we want to have the option specify what branch and repo to build.2) We want to skip some test if we are just building the operator.
Description of changes:
Added three new input fields. Two of them determine what branch to checkout that default to
github.shaandgitub.repo, addressing issue 1. The third field determines if tests should be ran before upload and is enabled by default.Testing
https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/11748848783
newer: https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/12283648904
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.