Fix command for java auto instrumentation on windows nodes #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
approved these changes
Jun 18, 2024
|
|
||
| var ( | ||
| commandLinux = []string{"cp", "/javaagent.jar", javaInstrMountPath + "/javaagent.jar"} | ||
| commandWindows = []string{"CMD", "/c", "copy", "javaagent.jar", javaInstrMountPathWindows} |
There was a problem hiding this comment.
Just curious is there a reason why we use CMD /c instead of Copy-Item?
There was a problem hiding this comment.
windows nanoserver doesn't come with powershell so the sdk container wouldn't be able to run Copy-Item directly:
Command:
Copy-Item
javaagent.jar
\otel-auto-instrumentation-java
State: Waiting
Reason: RunContainerError
Last State: Terminated
Reason: StartError
Message: failed to start containerd task "a8f40a5dc034e4a566e577b42d0e86cd8d9e96ca70817c696b6a57bd5f32d39b": hcs::System::CreateProcess a8f40a5dc034e4a566e577b42d0e86cd8d9e96ca70817c696b6a57bd5f32d39b: The system cannot find the file specified.: unknown
Exit Code: 128
...
There was a problem hiding this comment.
Updated the description to not say powershell, but just cmd.exe
movence
reviewed
Jun 18, 2024
| javaInitContainerName = initContainerName + "-java" | ||
| javaVolumeName = volumeName + "-java" | ||
| javaInstrMountPath = "/otel-auto-instrumentation-java" | ||
| javaInstrMountPathWindows = "\\otel-auto-instrumentation-java" |
There was a problem hiding this comment.
do we need a test case for this?
There was a problem hiding this comment.
Test case was added in func TestInjectJavaagentWindows
movence
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The above will be injected for pods with the
kubernetes.io/os: windowsnode selector. The EKS documentation requires this selector be added to pods.This will not enable support for windows. The operator still needs a windows build of the auto instrumentation image.
Tested using a dev build on a windows node and saw java app running:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.