Added tolerations support for dcgmexporter and neuronmonitor. #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In order to support tolerations for aws-observability/helm-charts#41, we need to update these files in the operator to add tolerations for dcgmexporter and neuronmonitor.
How I tested:
I observed that for (1), tainted nodes never ran any services as expected, but there were no errors. Before setting up (2), I ran into the following error:
However, it was resolved after updating CRDs with
kubectl apply -f helm-charts/charts/amazon-cloudwatch-observability/crds
in the updatedhelm-charts
branch, which means there are no issues for both (1) and (2). Also, (2) didn't run changes for thedcgmexporter
, which was expected since the change this PR intends to make isn't being applied:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.