[DO NOT MERGE] Add TLS certification to operator #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
force-pushed
the
tls-operator
branch
2 times, most recently
from
238daf1 to
a4d8f97
Compare
okankoAMZ
force-pushed
the
tls-operator
branch
3 times, most recently
from
9eb6657 to
517a1be
Compare
Added injection Adding unit tests Fixing unit tests added volume mount Added seperate volume mount for tls added volume mount unit tests
okankoAMZ
force-pushed
the
tls-operator
branch
23 times, most recently
from
e582906 to
9048fd0
Compare
okankoAMZ
force-pushed
the
tls-operator
branch
2 times, most recently
from
4dc2373 to
a0ec0bf
Compare
Changed append structure Added guard-rails
okankoAMZ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We want to support TLS connection between Operator and Application Signals, to do that the TLS CA bundle certification must be passed to the customer's namespaces.
Important
With kubernaties you cannot share secrets between namespaces natively, you either need use a third-party syncing tool or copy it over.
Description of changes:
In this PR, we are reading the secret generated by helm-charts(see the warning below) using volume mount, then injecting that using a init-container. This container save this as a local file to be used in TLS process, creating a secure network layer.
Warning
This PR cannot be merged until the helm-chart PR is merged.
Testing
Here we can see that the init containers are attached properly
Here we can see that all volume mounts are correct
cat cert-volume/amazon-cloudwatch-agent/ca.crtHere we can see that the cert is saved successfully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.