Modifying operator test for python and java simultaneous instrumentation #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonjavaInstrumentation
…udwatch-agent-operator into pythonjavaInstrumentation
lisguo
reviewed
Apr 29, 2024
lisguo
reviewed
Apr 30, 2024
lisguo
reviewed
May 3, 2024
Paramadon
force-pushed
the
pythonjavaInstrumentation
branch
from
688f81e to
148ade7
Compare
lisguo
approved these changes
May 6, 2024
musa-asad
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We have tests that account for python and java individually, but not for when they are both injected into a pod simultaneously. Can use validation method to verify env variables: https://github.com/aws/amazon-cloudwatch-agent-operator/blob/main/integration-tests/manifests/cmd/validate_instrumentation_vars.go.
Description of changes:
Modified operator test to account for python and java running simultaneously.
AC:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.