Refactor with strands #902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update _extract_reasoning_content_from_agent_result to handle Strands' actual reasoning structure - Change from looking for 'type' == 'reasoning' to 'reasoningContent' key - Extract reasoning text from reasoningContent.reasoningText.text path - Use actual signature from Strands instead of hardcoded value - Ensure reasoning content is properly added to thinking_log for persistence - Align with chat_legacy logic for reasoning content handling
|
Memo: reflect #927 as well |
Yukinobu-Mine
force-pushed
the
refactor-strands
branch
from
8de3bac to
c657ee8
Compare
- Split `chat()` into common and framework specific implementation. 1. (Common preprocess) Setup messages and LLM parameters. 2. (Framework specific) Converse with LLM and build response messages. 3. (Common postprocess) Update conversation and store into database. - Consolidate the code for converting between application-defined models (messages, contents and tools) and Strands models into `converters` module. - Fix some bugs in streaming processing - Fail to continue generation based on a message with `ReasoningContent`. - Not handling `redactedContent` correctly.
Yukinobu-Mine
force-pushed
the
refactor-strands
branch
from
c657ee8 to
48a1ea5
Compare
|
When is it scheduled to be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
close #897
Description of changes:
To introduce MCP support (#866), refactor to replace current implementation with strands SDK
Tool Implementation
BeforeToolInvocationEvent/AfterToolInvocationEvent) to includesource_idfor citation support.Chat Routing System
chat()into common and framework specific implementation.USE_STRANDS == true→ Routes toconverse_with_strands()(Strands implementation)USE_STRANDS == false→ Routes toconverse_legacy()(original implementation with deprecation warning)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.