Skip to content

Unicorn approvals #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Unicorn approvals #175

wants to merge 8 commits into from

Conversation

sliedig
Copy link
Contributor

@sliedig sliedig commented Jul 7, 2025

Summary

Changes

This pull request refactors the Unicorn Properties service into Unicorn Approvals service, updating the namespace and service naming throughout the codebase. The main changes include:

  • Service Rename: Renamed Unicorn.Properties to Unicorn.Approvals throughout the codebase
  • Namespace Updates: Updated all references from UnicornPropertiesNamespace to UnicornApprovalsNamespace
  • Event Bus References: Updated all event bus references from UnicornPropertiesEventBus to UnicornApprovalsEventBus
  • Documentation Updates: Updated README files and documentation to reflect the new service name

User experience

Before: The service was named "Unicorn Properties" which could be confusing as it handled approval workflows rather than property management directly.

After: The service is now named "Unicorn Approvals" which more accurately reflects its purpose of handling approval workflows for contracts and properties. This provides better clarity for developers and users about the service's actual functionality.

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sliedig sliedig requested a review from a team as a code owner July 7, 2025 00:33
@github-actions github-actions bot requested a review from igorlg July 7, 2025 00:33
@sliedig sliedig requested review from marcobuss and removed request for igorlg July 7, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants