Skip to content

Add permissions to create service-linked role #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025
Merged

Add permissions to create service-linked role #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddf1870
add permissions to create service-linked role
Jun 16, 2025
98441cb
Merge remote-tracking branch 'origin/main' into cloudtrail-305
Jun 16, 2025
10d8dea
update github workflow to run cfn-nag
Jun 16, 2025
f0a22a6
update CHANGELOG.md
Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cfn-nag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Ruby 2.6
- name: Set up Ruby 2.7
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.6'
ruby-version: '2.7'
- name: Install cfn-nag
run: gem install cfn-nag
- name: Scan files in all templates folders
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Table of Contents<!-- omit in toc -->

- [Introduction](#introduction)
- [2025-06-16](#2025-06-16)
- [2025-03-20](#2025-03-20)
- [2025-03-04](#2025-03-04)
- [2025-02-13](#2025-02-13)
Expand Down Expand Up @@ -63,6 +64,11 @@
All notable changes to this project will be documented in this file.

---
## 2025-06-16

### Updated<!-- omit in toc -->

- Updated [CloudTrail](https://github.com/aws-samples/aws-security-reference-architecture-examples/tree/main/aws_sra_examples/solutions/cloudtrail/cloudtrail_org) solution with permissions to create a service-linked role.

## 2025-03-20

Expand Down
5 changes: 4 additions & 1 deletion aws_sra_examples/solutions/cloudtrail/cloudtrail_org/templates/sra-cloudtrail-org.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ Resources:
- iam:DeleteServiceLinkedRole
Resource:
- !Sub arn:${AWS::Partition}:iam::${AWS::AccountId}:role/aws-service-role/cloudtrail.amazonaws.com/AWSServiceRoleForCloudTrail*
- !Sub arn:${AWS::Partition}:iam::${AWS::AccountId}:role/aws-service-role/context.cloudtrail.amazonaws.com/AWSServiceRoleForCloudTrailEventContext
Tags:
- Key: sra-solution
Value: !Ref pSRASolutionName
Expand All @@ -425,6 +426,8 @@ Resources:
comment: Lambda does not need to communicate with VPC resources.
- id: CKV_AWS_173
comment: Environment variables are not sensitive
- id: CKV_AWS_45
comment: Environment variables only contain non-sensitive configuration values that are passed via CloudFormation parameters.
Properties:
Description: Creates an Organization CloudTrail
Architectures: !If
Expand Down Expand Up @@ -473,4 +476,4 @@ Resources:
KMS_KEY_ID: !Ref pOrganizationCloudTrailKMSKeyId
S3_BUCKET_NAME: !Ref pCloudTrailS3BucketName
SRA_SOLUTION_NAME: !Ref pSRASolutionName
DELEGATED_ADMIN_ACCOUNT_ID: !Ref pDelegatedAdminAccountId
DELEGATED_ADMIN_ACCOUNT_ID: !Ref pDelegatedAdminAccountId