Skip to content

Update to Dockerfile to Use Rust 1.87 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

yiyuan-he
Copy link
Contributor

What does this pull request do?

Updates the Rust version used in our Dockerfile to support edition2024. At least 1.85 is required, so went ahead and bumped to latest available version 1.87.

#16 3.449 error: failed to compile `cargo-audit v0.21.2`, intermediate artifacts can be found at `/tmp/cargo-installyA5rTL`.
#16 3.449 To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
#16 3.449 
#16 3.449 Caused by:
#16 3.449   failed to parse manifest at `/usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cvss-2.1.0/Cargo.toml`
#16 3.449 
#16 3.449 Caused by:
#16 3.449   feature `edition2024` is required
#16 3.449 
#16 3.449   The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.82.0 (8f40fc59f 2024-08-21)).
#16 3.449   Consider trying a newer version of Cargo (this may require the nightly release).
#16 3.449   See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.
#16 ERROR: process "/bin/sh -c if [ $TARGETARCH = \"amd64\" ]; then cargo install cargo-audit && cargo audit ; fi" did not complete successfully: exit code: 101

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yiyuan-he yiyuan-he requested a review from a team as a code owner June 9, 2025 04:43
@yiyuan-he yiyuan-he merged commit 61e4963 into aws-observability:main Jun 9, 2025
17 of 18 checks passed
@yiyuan-he yiyuan-he deleted the update-docker branch June 9, 2025 17:27
srprash pushed a commit to aws-observability/aws-otel-js-instrumentation that referenced this pull request Jun 13, 2025
## What does this pull request do?
Proactively bumping rust version in our Dockerfile to 1.87 to align with
our ADOT Python SDK repo:
aws-observability/aws-otel-python-instrumentation#386

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants