Skip to content

Enable suppressInternalInstrumentation for AWS-SDK and Mongoose Instrumentations #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Sep 19, 2024

Issue #, if available:

Description of changes:

  1. Enable suppressInternalInstrumentation for AWS-SDK and Mongoose Instrumentations
  2. Remove workaround that suppresses metrics from child spans of AWS SDK spans

Testing:

  • Tested on ECS Fargate and Local machine
    • AWS SDK has no http child span
    • Mongoose has no mongodb child span

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from a team as a code owner September 19, 2024 02:49
@jj22ee jj22ee merged commit 7dabd39 into main Sep 19, 2024
8 checks passed
@jj22ee jj22ee deleted the suppress-internal-lib branch September 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants