Skip to content

Update README regarding Env Vars, Reorder Env Detector in Env Var logic #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Sep 17, 2024

Issue #, if available:

Description of changes:

  1. Add General Recommendations table for ADOT JS Env Vars.
  2. If user sets the OTEL_NODE_RESOURCE_DETECTORS Env Var, ensure that env is at the end of the list if not added by user. (see related #53)

Testing:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from a team as a code owner September 17, 2024 23:31
@jj22ee jj22ee force-pushed the readme-env-var-update branch from 398087a to f6db901 Compare September 18, 2024 00:01
@pxaws pxaws merged commit 93fffad into main Sep 18, 2024
8 checks passed
@pxaws pxaws deleted the readme-env-var-update branch September 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants