Skip to content

Optimize Instrumentation Configure for Lambda cases #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

mxiamxia
Copy link
Member

Description of changes:
Update Instrumentation Configure for the following changes

  1. Disable AwsSpanMetricsProcessor for Lambda
  2. Disable AWS platform Resource Detectors for Lambda
  3. Update Lambda Instrumentation propagation for supporting PassThru case
  4. Update Lambda Local Operation to {function_name}/Hander
  5. Set Batch Sampled/UnSampled Span processor size to 10 for Lambda only

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxiamxia mxiamxia force-pushed the aws-lambda-configurator branch from 6ce865c to 89e054c Compare September 17, 2024 17:11
@mxiamxia mxiamxia marked this pull request as ready for review September 17, 2024 17:12
@mxiamxia mxiamxia requested a review from a team as a code owner September 17, 2024 17:12
@mxiamxia mxiamxia requested review from wangzlei and jj22ee September 17, 2024 17:12
wangzlei
wangzlei previously approved these changes Sep 17, 2024
Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@mxiamxia mxiamxia force-pushed the aws-lambda-configurator branch 2 times, most recently from 536a8c0 to 4941b36 Compare September 17, 2024 19:55
@mxiamxia mxiamxia force-pushed the aws-lambda-configurator branch from 4941b36 to 2b76e83 Compare September 17, 2024 20:13
wangzlei
wangzlei previously approved these changes Sep 17, 2024
@mxiamxia mxiamxia removed the request for review from jj22ee September 18, 2024 00:46
pxaws
pxaws previously approved these changes Sep 18, 2024
@mxiamxia mxiamxia dismissed stale reviews from pxaws and wangzlei via ae7efe3 September 18, 2024 16:50
@mxiamxia mxiamxia force-pushed the aws-lambda-configurator branch from ae7efe3 to 266fbd7 Compare September 18, 2024 18:21
@pxaws pxaws merged commit 5e967ac into aws-observability:main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants