Skip to content

Fix: Deprecated GitHub Artifacts #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

yiyuan-he
Copy link
Contributor

Issue #, if available:
Github workflows are failing due to:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

A downstream effect of upgrading to v4 is this version no longer allows uploading artifacts with same name.
See: https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1014/files

Description of changes:
We apply the same fix in the above PR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yiyuan-he yiyuan-he requested a review from a team as a code owner February 11, 2025 22:41
@yiyuan-he yiyuan-he changed the title fix deprecated github artifacts Fix: Deprecated GitHub artifacts Feb 11, 2025
@yiyuan-he yiyuan-he changed the title Fix: Deprecated GitHub artifacts Fix: Deprecated GitHub Artifacts Feb 11, 2025
@yiyuan-he yiyuan-he merged commit 984144d into aws-observability:main Feb 11, 2025
9 checks passed
yiyuan-he added a commit that referenced this pull request Feb 12, 2025
*Issue #, if available:*
The previous fix did not work because `download-artifacts@v3` is also
deprecated and must be updated.
```
Error: This request has been automatically failed because it uses a deprecated version of `actions/download-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
```

Previous fix:
#152

*Description of changes:*
- Updating `download-artifacts@v3` to `v4`.
- Also fixing syntax error for name pattern.


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants