Skip to content

Allow customer to manipulate auto-insstrumention both enable/disable #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mxiamxia
Copy link
Member

Description of changes:
Fully support NodeJS enable/disable configuration

if both OTEL_NODE_ENABLED_INSTRUMENTATIONS and OTEL_NODE_DISABLED_INSTRUMENTATIONS are not configured, set OTEL_NODE_ENABLED_INSTRUMENTATIONS="aws-sdk,aws-lambda"
else if OTEL_NODE_ENABLED_INSTRUMENTATIONS is configure and OTEL_NODE_DISABLED_INSTRUMENTATIONS is not, append OTEL_NODE_ENABLED_INSTRUMENTATIONS with "aws-lambda"
else if both OTEL_NODE_ENABLED_INSTRUMENTATIONS and OTEL_NODE_DISABLED_INSTRUMENTATIONS are configured, append OTEL_NODE_ENABLED_INSTRUMENTATIONS with "aws-lambda"
else do nothing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxiamxia mxiamxia marked this pull request as ready for review October 24, 2024 00:17
@mxiamxia mxiamxia requested a review from a team as a code owner October 24, 2024 00:17
Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzlei wangzlei merged commit 2b0a46e into aws-observability:main Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants