feat: New pattern EKS AutoMode custom nodepools #2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abencomoc
changed the title
askulkarni2
requested changes
Mar 12, 2025
askulkarni2
requested changes
Apr 11, 2025
There was a problem hiding this comment.
@abencomoc thanks for making the updates. I do some additional minor revisions. Then we are good to go.
patterns/eks-automode/automode-custom-nodepools/eks-automode-config.tf
Outdated
Show resolved
Hide resolved
patterns/eks-automode/automode-custom-nodepools/eks-automode-config.tf
Outdated
Show resolved
Hide resolved
...erns/eks-automode/automode-custom-nodepools/eks-automode-config/nodeclass-ebs-optimized.yaml
Show resolved
Hide resolved
patterns/eks-automode/automode-custom-nodepools/eks-automode-config/nodeclass-basic.yaml
Show resolved
Hide resolved
askulkarni2
reviewed
May 9, 2025
patterns/eks-automode/automode-custom-nodepools/eks-automode-config.tf
Outdated
Show resolved
Hide resolved
patterns/eks-automode/automode-custom-nodepools/eks-automode-config.tf
Outdated
Show resolved
Hide resolved
askulkarni2
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new pattern to show how to use EKS AutoMode with custom nodePool and nodeClass (default AutoMode nodePool disabled)
Motivation and Context
How was this change tested?
The pattern includes a sample app the the user deploy to see different custom NodePools in action -> retail app github page
pre-commit run -awith this PRAdditional Notes
As shown in the README file, I ./install the pattern and deploy a sample application. All app components get to Running state using different nodepools and I can access the app using the provisioned ALB.