-
Notifications
You must be signed in to change notification settings - Fork 7
Remove ggtest temporary folder #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test1.py
Outdated
# When I corrupt the contents of the component HelloWorld version 1.0.0 in the S3 bucket | ||
assert gg_util_obj.upload_corrupt_artifacts_to_s3("HelloWorld", | ||
"1.0.0") == True | ||
assert gg_util_obj.upload_corrupt_artifacts_to_s3("HelloWorld", "1.0.0") == True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The ==
and !=
operators use the compared objects' __eq__
method to test if they are equal. To check if an object is a singleton, such as None
, we recommend that you use the is
identity comparison operator.
Similar issue at line number 488.
c81ad23
to
a659644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
) | ||
== True | ||
) | ||
assert (system_interface.monitor_journalctl_for_message( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The ==
and !=
operators use the compared objects' __eq__
method to test if they are equal. To check if an object is a singleton, such as None
, we recommend that you use the is
identity comparison operator.
) | ||
== True | ||
) | ||
assert (system_interface.monitor_journalctl_for_message( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The ==
and !=
operators use the compared objects' __eq__
method to test if they are equal. To check if an object is a singleton, such as None
, we recommend that you use the is
identity comparison operator.
Issue #, if available:
Description of changes:
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.