Skip to content

Conversation

jiangpta
Copy link
Contributor

Issue #, if available:
n/a
Description of changes:
ported tests in shadow8
Why is this change necessary:
adding UAT tests for shadow manager
How was this change tested:
n/a
Any additional information or context required to review the change:
n/a

Checklist:

  • Updated the README if applicable
  • Updated or added new unit tests
  • Updated or added new integration tests
  • If your code makes a remote network call, it was tested with a proxy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines 59 to 60
"ShadowDocument": "{\"state\":{\"reported\":{\"color\":{\"r\":255,\"g\":255,\"b\":255},\"SomeKey\":\"SomeValue\"}}}",
"ExpectedShadowDocument": "{\"version\":1,\"state\":{\"reported\":{\"color\":{\"r\":255,\"g\":255,\"b\":255},\"SomeKey\":\"SomeValue\"}}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the shadow documents should have \\\. Other than that, rest of the PR looks good.

@MikeDombo MikeDombo force-pushed the main branch 2 times, most recently from 4263e0e to 2e8d744 Compare April 12, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants