Add ggl buffer copy api #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicityzhao9
approved these changes
Oct 16, 2025
archigup
reviewed
Oct 17, 2025
| GglError ggl_buf_copy(GglBuffer source, GglBuffer *target) { | ||
| if (source.len == 0) { | ||
| target->len = 0; | ||
| GGL_LOGD("Source has zero length buffer"); |
There was a problem hiding this comment.
This should not be a log? Thats a valid case that happens often
archigup
reviewed
Oct 17, 2025
| GGL_LOGT("Failed to copy buffer due to insufficient space."); | ||
| return GGL_ERR_NOMEM; | ||
| } | ||
| memcpy(target->data, source.data, source.len); |
There was a problem hiding this comment.
This doesn't set the target len?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.