Skip to content

fix: remove warning when limit is set to 0 #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove warning when limit is set to 0 #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...main/java/com/aws/greengrass/util/platforms/unix/linux/LinuxSystemResourceController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public void updateResourceLimits(GreengrassService component, Map<String, Object
long memoryLimitInKB = Coerce.toLong(resourceLimit.get(MEMORY_KEY));
if (memoryLimitInKB > 0) {
memoryManager.setMemoryLimit(component.getServiceName(), memoryLimitInKB);
} else {
} else if (memoryLimitInKB < 0) {
logger.atWarn().kv(COMPONENT_NAME, component.getServiceName()).kv(MEMORY_KEY, memoryLimitInKB)
.log("The provided memory limit is invalid");
}
Expand All @@ -128,7 +128,7 @@ public void updateResourceLimits(GreengrassService component, Map<String, Object
double cpu = Coerce.toDouble(resourceLimit.get(CPUS_KEY));
if (cpu > 0) {
cpuManager.setCpuLimit(component.getServiceName(), cpu);
} else {
} else if (cpu < 0) {
logger.atWarn().kv(COMPONENT_NAME, component.getServiceName()).kv(CPUS_KEY, cpu)
.log("The provided cpu limit is invalid");
}
Expand Down
Loading