-
Notifications
You must be signed in to change notification settings - Fork 51
fix: account for recheck value to be null #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8e0191c |
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8e0191c |
alter-mage
reviewed
Oct 15, 2025
src/main/java/com/aws/greengrass/lifecyclemanager/UpdateSystemPolicyService.java
Outdated
Show resolved
Hide resolved
4f32f71
to
e5d3dd7
Compare
junfuchen99
previously approved these changes
Oct 15, 2025
alter-mage
previously approved these changes
Oct 15, 2025
e5d3dd7
to
7d84b3c
Compare
7d84b3c
to
690e990
Compare
junfuchen99
approved these changes
Oct 16, 2025
alter-mage
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
the sdk allows you to not pass a value for the recheck time. If this happens the nucleus is stuck in a broken state. Adding a null check and a default value to prevent this.
Why is this change necessary:
This issue is hard to require from and requires access to the device.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.