fix: remove processing information of unwanted files #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Sep 15, 2025
saranyailla
force-pushed
the
fix-processing-config
branch
from
834c4d0 to
970759c
Compare
src/test/java/com/aws/greengrass/logmanager/LogManagerServiceTest.java
Outdated
Show resolved
Hide resolved
saranyailla
force-pushed
the
fix-processing-config
branch
from
806b821 to
4c303dc
Compare
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4bb27bd |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4bb27bd |
src/integrationtests/java/com/aws/greengrass/integrationtests/logmanager/LogManagerTest.java
Show resolved
Hide resolved
| // Must set an MDC adapter for 1.3.8+. https://github.com/qos-ch/logback/issues/709 | ||
| loggerContext.setMDCAdapter(new NOPMDCAdapter()); | ||
| loggerContext.setMDCAdapter(new BasicMDCAdapter()); | ||
| // loggerContext.setMDCAdapter(new NOPMDCAdapter()); |
There was a problem hiding this comment.
Nit: Remove instead of commenting out
| import ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy; | ||
| import ch.qos.logback.core.util.FileSize; | ||
| import org.slf4j.helpers.BasicMDCAdapter; | ||
| import org.slf4j.helpers.NOPMDCAdapter; |
kstribrnAmzn
approved these changes
Sep 23, 2025
|
Approving as my comments are mostly nit-picks. |
alter-mage
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
lastComponentUploadedTimeparameter to bothloadProcessingFilesConfig()andloadProcessingFilesConfigDeprecated()to not load stale information from the persisted configuration.Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.