Skip to content

Conversation

cookpate
Copy link
Member

@cookpate cookpate commented Oct 17, 2025

Issue #, if available:

  • If components are restarted for any reason, this increments the restart counter towards its burst limit.

Description of changes:

  • Add global reset-failed on gghealthd startup
  • Add reset-failed of a single component on RestartComponent IPC

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cookpate cookpate force-pushed the reset_failed_on_reboot branch from 4f5e4d8 to 17732e0 Compare October 17, 2025 17:12
Comment on lines 221 to 234
sd_bus_error reset_error = SD_BUS_ERROR_NULL;
sd_bus_message *reset_reply = NULL;
int reset_ret = sd_bus_call_method(
bus,
"org.freedesktop.systemd1",
"/org/freedesktop/systemd1",
"org.freedesktop.systemd1.Manager",
"ResetFailedUnit",
&reset_error,
&reset_reply,
"s",
(char *) qualified_name
);
GGL_CLEANUP(sd_bus_error_free, reset_error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is also the reset logic

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove that as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also probably reset after the restart no?

@cookpate cookpate force-pushed the reset_failed_on_reboot branch from 17732e0 to fb89138 Compare October 17, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants