Enhance solidmodel boundary methods #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simlapointe
commented
May 22, 2025
simlapointe
commented
- Enhance the SolidModel get_boundary method to optionally return only boundaries perpendicular to specified directions and only at the min/max position along the specified direction. This is useful if the user wishes to apply different boundary conditions on different exterior boundary faces.
- Introduce the set_periodic method to make the mesh on the specified groups periodic. Currently only supports 2D groups representing parallel axis-aligned surfaces (i.e. can only apply periodicity in the X, Y, or Z direction).
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
gpeairs
reviewed
May 23, 2025
src/solidmodels/postrender.jl
Outdated
| end | ||
|
|
||
| """ | ||
| set_periodic!(group1::AbstractPhyiscalGroup, group2::AbstractPhyiscalGroup; dim=2) |
src/solidmodels/postrender.jl
Outdated
| end | ||
| end | ||
|
|
||
| function get_physical_group_bounding_box(dim, tags) |
There was a problem hiding this comment.
Just checking, tags should be entity tags, not physical group tags, right? I would just call it get_bounding_box.
There was a problem hiding this comment.
Correct, they should be entity tags. I renamed the function as you suggested.
There was a problem hiding this comment.
Just remembered there's also a function SolidModels.bounds3d with a slightly different interface, oops. There's a docstring but it's not in the HTML docs yet (adding it as part of #58).
simlapointe
force-pushed
the
simlapointe/sm-boundary-periodic
branch
from
d7573a1 to
2f4d74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.