Skip to content

Another branch #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-05-13T05:08:46Z"
build_hash: 55bf57b2806c33a7fcd074be403f26ce3f8e58db
go_version: go1.24.2
version: v0.46.2
build_date: "2025-05-22T21:41:04Z"
build_hash: ed3e8afd0209bee26809ca6d6a72b1a8e3e05ede
go_version: go1.24.3
version: v0.46.2-5-ged3e8af-dirty
api_directory_checksum: e0465b8e0cf7076ab51e30604f13a32cdf4957ae
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
Expand Down
24 changes: 13 additions & 11 deletions pkg/resource/function/hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,36 +69,38 @@ func (rm *resourceManager) customUpdateFunction(
exit := rlog.Trace("rm.customUpdateFunction")
defer exit(err)

if isFunctionPending(desired) {
return nil, requeueWaitWhilePending
updatedStatusResource := rm.concreteResource(desired.DeepCopy())
updatedStatusResource.SetStatus(latest)
if isFunctionPending(latest) {
return updatedStatusResource, requeueWaitWhilePending
}

if delta.DifferentAt("Spec.Tags") {
err = rm.updateFunctionTags(ctx, latest, desired)
if err != nil {
return nil, err
return updatedStatusResource, err
}
}
if delta.DifferentAt("Spec.ReservedConcurrentExecutions") {
err = rm.updateFunctionConcurrency(ctx, desired)
if err != nil {
return nil, err
return updatedStatusResource, err
}
}
if delta.DifferentAt("Spec.FunctionEventInvokeConfig") {
err = rm.syncFunctionEventInvokeConfig(ctx, desired)
if err != nil {
return nil, err
return updatedStatusResource, err
}
}
if delta.DifferentAt("Spec.CodeSigningConfigARN") {
if desired.ko.Spec.PackageType != nil && *desired.ko.Spec.PackageType == "Image" &&
desired.ko.Spec.CodeSigningConfigARN != nil && *desired.ko.Spec.CodeSigningConfigARN != "" {
return nil, ackerr.NewTerminalError(ErrCannotSetFunctionCSC)
return updatedStatusResource, ackerr.NewTerminalError(ErrCannotSetFunctionCSC)
} else {
err = rm.updateFunctionCodeSigningConfig(ctx, desired)
if err != nil {
return nil, err
return updatedStatusResource, err
}
}
}
Expand All @@ -112,9 +114,9 @@ func (rm *resourceManager) customUpdateFunction(
err = rm.updateFunctionCode(ctx, desired, delta, latest)
if err != nil {
if strings.Contains(err.Error(), "Provide a valid source image.") {
return nil, requeueWaitWhileSourceImageDoesNotExist
return updatedStatusResource, requeueWaitWhileSourceImageDoesNotExist
} else {
return nil, err
return updatedStatusResource, err
}
}
case delta.DifferentExcept(
Expand All @@ -125,13 +127,13 @@ func (rm *resourceManager) customUpdateFunction(
"Spec.CodeSigningConfigARN"):
err = rm.updateFunctionConfiguration(ctx, desired, delta)
if err != nil {
return nil, err
return updatedStatusResource, err
}
}

readOneLatest, err := rm.ReadOne(ctx, desired)
if err != nil {
return nil, err
return updatedStatusResource, err
}
return rm.concreteResource(readOneLatest), nil
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/resource/function/manager.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/resource/function/sdk.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions templates/hooks/function/sdk_read_one_post_set_output.go.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,5 @@
ko.Spec.Tags = expectedOutput
}
if err := rm.setResourceAdditionalFields(ctx, ko); err != nil {
return nil, err
}
return &resource{ko}, err
}