Skip to content

chore: update lint-staged to v15, cspell to v8, bump sass to latest #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented Jun 17, 2024

Description of changes:

  • updates lint-staged to latest v15 (we were on 14). When we originally implemented linting, we could not update to the latest because we had not updated to newer version of node but now we have. Verified that linting runs on staged files when making a commit
  • updates cspell to latest v8 (we were on v6). Verified by making some mispelled words.
  • bumps sass to latest (we were just a couple minor versions behind), verified output on staging site https://updatelintstaged.d2bfwhpcsj9awv.amplifyapp.com/

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hbuchel hbuchel changed the title chore: update lint-staged to v15 chore: update lint-staged to v15, cspell to v8, bump sass to latest Jun 18, 2024
@hbuchel hbuchel marked this pull request as ready for review June 18, 2024 20:50
@hbuchel hbuchel requested a review from a team as a code owner June 18, 2024 20:50
@hbuchel hbuchel merged commit cd1ed39 into main Jun 18, 2024
11 checks passed
@hbuchel hbuchel deleted the UpdateLintStaged branch June 18, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants