Skip to content

fix: heading order on subscribe-data page #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: heading order on subscribe-data page #7739

merged 1 commit into from
Jun 14, 2024

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented Jun 13, 2024

Description of changes:

Fixes the accessibility violations on this page related to heading order. Noticed they were failing in this run: https://github.com/aws-amplify/docs/actions/runs/9504729443/job/26198027563?pr=7738

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hbuchel hbuchel requested a review from a team as a code owner June 13, 2024 19:49
@hbuchel hbuchel enabled auto-merge (squash) June 13, 2024 20:06
@hbuchel hbuchel merged commit d383a42 into main Jun 14, 2024
11 checks passed
@hbuchel hbuchel deleted the HeadingOrderFix branch June 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants