Skip to content

fix(js): Add 1.1.x version for js React Native v5 push notification #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

yuhengshs
Copy link
Contributor

Description of changes:

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@renebrandel renebrandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on wording.

yuhengshs and others added 3 commits June 3, 2024 09:18
…tarted/40_install_lib.mdx


Adjusted working suggested by Rene

Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Adjusted the wording of call out for v5 supported rtn-push-notification version
@yuhengshs yuhengshs requested a review from renebrandel June 3, 2024 17:22
@yuhengshs yuhengshs marked this pull request as ready for review June 3, 2024 17:37
@renebrandel renebrandel enabled auto-merge (squash) June 3, 2024 17:40
@renebrandel renebrandel merged commit 20c9fb9 into main Jun 5, 2024
10 checks passed
@renebrandel renebrandel deleted the js-undefined-is-an-object-yuhengsh branch June 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants