Skip to content

feat: add accessibility Github Actions workflow #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented May 28, 2024

Description of changes:

Example run with violations:
https://github.com/aws-amplify/docs/actions/runs/9276059622/job/25522208433?pr=7669

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hbuchel hbuchel changed the title feat: add accessibility workflow feat: add accessibility Github Actions workflow May 28, 2024
@hbuchel hbuchel changed the title feat: add accessibility Github Actions workflow [DO NOT MERGE] feat: add accessibility Github Actions workflow May 29, 2024
@hbuchel hbuchel marked this pull request as ready for review June 6, 2024 16:01
@hbuchel hbuchel requested a review from a team as a code owner June 6, 2024 16:01
@hbuchel hbuchel changed the title [DO NOT MERGE] feat: add accessibility Github Actions workflow feat: add accessibility Github Actions workflow Jun 6, 2024
Comment on lines 15 to 18
.paginate(
'GET /repos/{owner}/{repo}/pulls/{pull_number}/files',
{ owner, repo, pull_number: issue_number },
(response) => response.data.filter((file) => (file.status === 'modified' || file.status === 'added'))
Copy link
Contributor

@timngyn timngyn Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking: Could we use async/await here? I know one of our utilities function started using await, but I know we still have other scripts using the promises chaining, so this comment isn't blocking

example of async and await from one of our scripts:

const deletedFiles = (
await github.paginate(
'GET /repos/{owner}/{repo}/pulls/{pull_number}/files',
{ owner, repo, pull_number: issue_number },
(response) => response.data
)
)
.filter((file) => file.status === 'removed')
.filter((file) => paths.some((path) => file.filename.startsWith(path)));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this in latest commit to use async/await instead (and some formatting/comment updates)

Copy link
Contributor

@timngyn timngyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, great job @hbuchel!!

@hbuchel hbuchel merged commit db85581 into main Jun 7, 2024
11 checks passed
@hbuchel hbuchel deleted the AddAxeWorkflow branch June 7, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants