adding unit tests #7581
Merged
adding unit tests #7581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2024 10:31
hbuchel
approved these changes
May 20, 2024
| it('should render the FeatureList component', async () => { | ||
| render(featureListComponent); | ||
|
|
||
| const heading = await screen.findByRole('heading', { name: 'Deploy' }); |
There was a problem hiding this comment.
Not blocking, but you can combine the H2 expect in this findByRole with:
await screen.findByRole('heading', { name: 'Deploy', level: 2 });
jacoblogan
reviewed
May 20, 2024
|
|
||
| const component = ( | ||
| <FeatureFlagSummary | ||
| key={`feature-flag-summary-${1}`} |
There was a problem hiding this comment.
nit: Can we remove this key prop? I'm not seeing why we need it here.
jacoblogan
reviewed
May 20, 2024
|
|
||
| const component = ( | ||
| <FeatureFlagSummary | ||
| key={`feature-flag-summary-${1}`} |
There was a problem hiding this comment.
Same as above, key seems unnecessary here.
jacoblogan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.