Skip to content

fix(ui): build failing when executing task "build:css" #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix(ui): build failing when executing task "build:css" #6623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/ui/scripts/generateCSS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import sass from 'sass';
import autoprefixer from 'autoprefixer';
import postcss from 'postcss';
import fs from 'fs-extra';
import path from 'path';
import { globSync } from 'glob';
import { createTheme } from '../src/theme';

Expand Down Expand Up @@ -29,8 +30,11 @@ function writeCSS(props: {
.process(result.css, { from: undefined })
.then((result) => {
result.warnings().forEach((warn) => {
// eslint-disable-next-line no-console
console.warn(warn.toString());
});
const dir = path.dirname(`dist/${outputPath}.css`);
fs.mkdirSync(dir, { recursive: true });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ensureDirSync instead of mkDirSync here? The former is safer and handles edge cases more gracefully.

Suggested change
fs.mkdirSync(dir, { recursive: true });
fs.ensureDirSync(dir);

fs.writeFileSync(`dist/${outputPath}.css`, result.css);
fs.writeFileSync(
`dist/${outputPath}.layer.css`,
Expand Down