Skip to content

feat: allow custom field on sign in #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fmonper1
Copy link

@fmonper1 fmonper1 commented Jun 4, 2025

Description of changes

This changes passes custom fields on the SignIn page to the relevant services.

Issue #, if available

#6570

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fmonper1 fmonper1 requested a review from a team as a code owner June 4, 2025 22:59
Copy link

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: 24b24bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@aws-amplify/ui Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch
@aws-amplify/ui-react-geo Patch
@aws-amplify/ui-test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ahmedhamouda78
Copy link
Member

Hello @fmonper1, thank you for the PR we will have a look and update you as soon as we have an update. Can you meanwhile please clarify how/if you tested this end-to-end?

@fmonper1
Copy link
Author

Hey there @ahmedhamouda78 , I haven't been able to test this locally since I'm unable to run the example packages locally.

I've been somewhat able to build the packages in the monorepo and I get some TS error related to this type https://github.com/aws-amplify/amplify-js/blob/main/packages/auth/src/providers/cognito/types/options.ts#L39-L46 not matching the signature of

          return services.handleSignIn({
            username,
            password: formValues.password,
            customFields,
          });

I'd be happy to add some test coverage If im able to run the examples locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants