Skip to content

feat(FaceLivenessDetectionError): Adding new .cameraNotAvailable error. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

sebaland
Copy link
Contributor

@sebaland sebaland commented Aug 2, 2024

Description of changes:

This PR adds FaceLivenessDetectionError.cameraNotAvailable, which is reported when there's a problem accessing the camera that is not caused by lack of user permissions.

The underlying websocket close code for this error remains 4006, as per the contract with the Rekognition service.

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
    • TBA
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland marked this pull request as ready for review August 2, 2024 17:49
@sebaland sebaland requested review from a team as code owners August 2, 2024 17:49
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.44%. Comparing base (8b3f63a) to head (387bff2).
Report is 3 commits behind head on main.

Files Patch % Lines
...ess/Views/Liveness/FaceLivenessDetectionView.swift 0.00% 2 Missing ⚠️
...iews/Liveness/FaceLivenessDetectionViewModel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   30.48%   30.44%   -0.05%     
==========================================
  Files          57       57              
  Lines        2227     2230       +3     
==========================================
  Hits          679      679              
- Misses       1548     1551       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebaland sebaland merged commit f13bf5e into main Aug 2, 2024
7 checks passed
@sebaland sebaland deleted the ruisebas/camera_error branch August 2, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants