fix: handle error on loading view #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantumcode
approved these changes
Jul 2, 2024
thisisabhash
added a commit
that referenced
this pull request
Aug 22, 2024
thisisabhash
added a commit
that referenced
this pull request
Jun 17, 2025
thisisabhash
added a commit
that referenced
this pull request
Jun 30, 2025
…#131) * feat: add no light challenge implementation (#127) * feat: add no light challenge implementation * update package.swift for CI build * Fix unit tests * Address review comments * chore: Add attempt count changes (#137) * chore: Add attempt count changes * Fix unit tests * add unit tests * Update region for example liveness view * Update amplify-swift dependency * chore: update dependencies after rebase * fix: handle error on loading view (#154) * chore: update amplify package dependency after rebase * update Package.resolved files * feat: add back camera support (#180) * chore: back camera support * Add code for error scenarios * update error codes and message * Add challengeOption parameter and remove error codes * Update ChallengeOptions and use camera position based on challenge type received * Add UI changes for selecting back camera in HostApp * add default parameter to ChallengeOptions init * fix formatting * fix test build * address review comments * remove unused property * update amplify dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Accessing StateObject's object without being installed on a View. This will create a new instance each time.Check points: (check or cross out if not relevant)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.