Skip to content

feat: add no-light/facemovementonly challenge and back camera support #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2025

Conversation

thisisabhash
Copy link
Member

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 35.74766% with 275 lines in your changes missing coverage. Please review.

Project coverage is 28.86%. Comparing base (3ab41b4) to head (a00e8fa).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ess/Views/Liveness/FaceLivenessDetectionView.swift 12.50% 105 Missing ⚠️
...iews/Liveness/FaceLivenessDetectionViewModel.swift 23.25% 66 Missing ⚠️
...s/Views/Instruction/InstructionContainerView.swift 0.00% 21 Missing ⚠️
...etectionViewModel+FaceDetectionResultHandler.swift 41.66% 21 Missing ⚠️
...ction/BlazeFace/FaceDetectorShortRange+Model.swift 0.00% 16 Missing ⚠️
...ceLiveness/Views/LoadingPage/LoadingPageView.swift 0.00% 12 Missing ⚠️
...FaceLiveness/Utilities/FinalClientEvent+Init.swift 0.00% 8 Missing ⚠️
...Liveness/Views/GetReadyPage/GetReadyPageView.swift 0.00% 8 Missing ⚠️
...ss/Views/GetReadyPage/CameraPreviewViewModel.swift 0.00% 4 Missing ⚠️
...veness/Views/Liveness/LivenessViewController.swift 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   29.05%   28.86%   -0.19%     
==========================================
  Files          57       58       +1     
  Lines        2802     3104     +302     
==========================================
+ Hits          814      896      +82     
- Misses       1988     2208     +220     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* feat: add no light challenge implementation

* update package.swift for CI build

* Fix unit tests

* Address review comments
* chore: Add attempt count changes

* Fix unit tests

* add unit tests

* Update region for example liveness view

* Update amplify-swift dependency
@thisisabhash thisisabhash marked this pull request as ready for review June 17, 2025 19:50
@thisisabhash thisisabhash requested review from a team as code owners June 17, 2025 19:56
* chore: back camera support

* Add code for error scenarios

* update error codes and message

* Add challengeOption parameter and remove error codes

* Update ChallengeOptions and use camera position based on challenge type received

* Add UI changes for selecting back camera in HostApp

* add default parameter to ChallengeOptions init

* fix formatting

* fix test build
@thisisabhash thisisabhash changed the title feat: add no-light/facemovementonly challenge support feat: add no-light/facemovementonly challenge and back camera support Jun 23, 2025
@thisisabhash thisisabhash requested a review from harsh62 June 23, 2025 19:38
@thisisabhash thisisabhash merged commit 94194cb into main Jun 30, 2025
7 of 8 checks passed
@thisisabhash thisisabhash deleted the feat/no-light-support branch June 30, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants