-
Notifications
You must be signed in to change notification settings - Fork 35
feat: add no-light/facemovementonly challenge and back camera support #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3073bf1
to
e8643b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 29.05% 28.86% -0.19%
==========================================
Files 57 58 +1
Lines 2802 3104 +302
==========================================
+ Hits 814 896 +82
- Misses 1988 2208 +220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
49b620c
to
bd97059
Compare
* feat: add no light challenge implementation * update package.swift for CI build * Fix unit tests * Address review comments
* chore: Add attempt count changes * Fix unit tests * add unit tests * Update region for example liveness view * Update amplify-swift dependency
bd97059
to
3557932
Compare
harsh62
reviewed
Jun 20, 2025
HostApp/HostApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
harsh62
reviewed
Jun 20, 2025
harsh62
reviewed
Jun 20, 2025
Sources/FaceLiveness/FaceDetection/BlazeFace/FaceDetectorShortRange+Model.swift
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
harsh62
reviewed
Jun 20, 2025
harsh62
reviewed
Jun 20, 2025
harsh62
reviewed
Jun 20, 2025
Sources/FaceLiveness/Views/Liveness/FaceLivenessDetectionView.swift
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
Sources/FaceLiveness/Views/Liveness/FaceLivenessDetectionView.swift
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
Sources/FaceLiveness/Views/Liveness/FaceLivenessDetectionView.swift
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
Sources/FaceLiveness/Views/Liveness/FaceLivenessDetectionView.swift
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
.../FaceLiveness/Views/Liveness/FaceLivenessDetectionViewModel+FaceDetectionResultHandler.swift
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
Sources/FaceLiveness/Views/Liveness/LivenessViewController.swift
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Jun 20, 2025
* chore: back camera support * Add code for error scenarios * update error codes and message * Add challengeOption parameter and remove error codes * Update ChallengeOptions and use camera position based on challenge type received * Add UI changes for selecting back camera in HostApp * add default parameter to ChallengeOptions init * fix formatting * fix test build
harsh62
reviewed
Jun 24, 2025
Sources/FaceLiveness/Views/Liveness/LivenessViewController.swift
Outdated
Show resolved
Hide resolved
harsh62
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check points: (check or cross out if not relevant)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.