Skip to content

chore: kickoff release #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nightly_repeated_unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ jobs:
scheme: ${{ matrix.scheme }}
timeout-minutes: 50
generate_coverage_report: false
test_iterations_flags: -test-iterations 100 -run-tests-until-failure
test_iterations_flags: -test-iterations 25 -run-tests-until-failure
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
}

func testMaxSubscriptionReached_throwMaxSubscriptionsReachedError() async throws {
let numOfMaxSubscriptionCount = 100
let numOfMaxSubscriptionCount = 200
let maxSubsctiptionsSuccess = expectation(description: "Client can subscribe to max subscription count")
maxSubsctiptionsSuccess.expectedFulfillmentCount = numOfMaxSubscriptionCount

Expand All @@ -149,7 +149,7 @@
return try await taskGroup.reduce([AnyCancellable?]()) { $0 + [$1] }
}

await fulfillment(of: [maxSubsctiptionsSuccess], timeout: 2)

Check failure on line 152 in AmplifyPlugins/API/Tests/APIHostApp/AWSAPIPluginFunctionalTests/AppSyncRealTimeClientTests.swift

View workflow job for this annotation

GitHub Actions / Functional Tests / API Integration Tests | Functional (iOS) / iOS Tests | AWSAPIPluginFunctionalTests

testMaxSubscriptionReached_throwMaxSubscriptionsReachedError, Asynchronous wait failed: Exceeded timeout of 2 seconds, with unfulfilled expectations: "Client can subscribe to max subscription count".

let maxSubscriptionReachedError = expectation(description: "Should return max subscription reached error")
maxSubscriptionReachedError.assertForOverFulfill = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import Foundation
import AWSS3
@_spi(SmithyReadWrite) import ClientRuntime
@_spi(UnknownAWSHTTPServiceError) @_spi(SmithyReadWrite) import AWSClientRuntime
@_spi(UnknownAWSHTTPServiceError) @_spi(SmithyReadWrite) @_spi(AWSEndpointResolverMiddleware) import AWSClientRuntime
import Smithy
import SmithyHTTPAPI
import SmithyRetries
Expand Down Expand Up @@ -60,12 +60,14 @@ extension UploadPartInput {
builder.retryStrategy(SmithyRetries.DefaultRetryStrategy(options: config.retryStrategyOptions))
builder.retryErrorInfoProvider(AWSClientRuntime.AWSRetryErrorInfoProvider.errorInfo(for:))
builder.applySigner(ClientRuntime.SignerMiddleware<UploadPartOutput>())
let endpointParams = EndpointParams(accelerate: config.accelerate ?? false, bucket: input.bucket, disableMultiRegionAccessPoints: config.disableMultiRegionAccessPoints ?? false, disableS3ExpressSessionAuth: config.disableS3ExpressSessionAuth, endpoint: config.endpoint, forcePathStyle: config.forcePathStyle ?? false, key: input.key, region: config.region, useArnRegion: config.useArnRegion, useDualStack: config.useDualStack ?? false, useFIPS: config.useFIPS ?? false, useGlobalEndpoint: config.useGlobalEndpoint ?? false)
context.set(key: Smithy.AttributeKey<EndpointParams>(name: "EndpointParams"), value: endpointParams)
builder.applyEndpoint(AWSClientRuntime.EndpointResolverMiddleware<UploadPartOutput, EndpointParams>(endpointResolverBlock: { [config] in try config.endpointResolver.resolve(params: $0) }, endpointParams: endpointParams))
let endpointParamsBlock = { [config] (context: Smithy.Context) in
EndpointParams(accelerate: config.accelerate ?? false, bucket: input.bucket, disableMultiRegionAccessPoints: config.disableMultiRegionAccessPoints ?? false, disableS3ExpressSessionAuth: config.disableS3ExpressSessionAuth, endpoint: config.endpoint, forcePathStyle: config.forcePathStyle ?? false, key: input.key, region: config.region, useArnRegion: config.useArnRegion, useDualStack: config.useDualStack ?? false, useFIPS: config.useFIPS ?? false, useGlobalEndpoint: config.useGlobalEndpoint ?? false)
}
context.set(key: Smithy.AttributeKey<EndpointParams>(name: "EndpointParams"), value: endpointParamsBlock(context))
builder.applyEndpoint(AWSClientRuntime.AWSEndpointResolverMiddleware<UploadPartOutput, EndpointParams>(paramsBlock: endpointParamsBlock, resolverBlock: { [config] in try config.endpointResolver.resolve(params: $0) }))
builder.selectAuthScheme(ClientRuntime.AuthSchemeMiddleware<UploadPartOutput>())
builder.interceptors.add(AWSClientRuntime.AWSS3ErrorWith200StatusXMLMiddleware<UploadPartInput, UploadPartOutput>())
builder.interceptors.add(AWSClientRuntime.FlexibleChecksumsRequestMiddleware<UploadPartInput, UploadPartOutput>(checksumAlgorithm: input.checksumAlgorithm?.rawValue))
builder.interceptors.add(AWSClientRuntime.FlexibleChecksumsRequestMiddleware<UploadPartInput, UploadPartOutput>(requestChecksumRequired: false, checksumAlgorithm: input.checksumAlgorithm?.rawValue, checksumAlgoHeaderName: "x-amz-sdk-checksum-algorithm"))
builder.serialize(UploadPartPresignedMiddleware())
var metricsAttributes = Smithy.Attributes()
metricsAttributes.set(key: ClientRuntime.OrchestratorMetricsAttributesKeys.service, value: "S3")
Expand Down
12 changes: 6 additions & 6 deletions Package.resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ let platforms: [SupportedPlatform] = [
.watchOS(.v9)
]
let dependencies: [Package.Dependency] = [
.package(url: "https://github.com/awslabs/aws-sdk-swift", exact: "1.0.69"),
.package(url: "https://github.com/awslabs/aws-sdk-swift", exact: "1.2.59"),
.package(url: "https://github.com/stephencelis/SQLite.swift.git", exact: "0.15.3"),
.package(url: "https://github.com/mattgallagher/CwlPreconditionTesting.git", from: "2.1.0"),
.package(url: "https://github.com/aws-amplify/amplify-swift-utils-notifications.git", from: "1.1.0")
Expand Down
Loading