fix(Auth): Fix Hosted UI continuation error #3715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3715 +/- ##
==========================================
+ Coverage 68.39% 68.43% +0.03%
==========================================
Files 1089 1089
Lines 37645 37651 +6
==========================================
+ Hits 25746 25765 +19
+ Misses 11899 11886 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| _ = try await plugin.signInWithWebUI(presentationAnchor: ASPresentationAnchor(), options: nil) | ||
| XCTFail("Should not succeed") | ||
| } catch { | ||
| guard case AuthError.service = error else { |
There was a problem hiding this comment.
nit: can we add an assert for .unableToStartASWebAuthenticationSession failure type?
There was a problem hiding this comment.
That is in the other test
thisisabhash
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#3678
Description
This solves an issue where a continuation was not able to resume due to a
canStartreturning false.General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.