Skip to content

refactor: use makeStream for creating AsyncStream with continuation #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

5d
Copy link
Contributor

@5d 5d commented May 17, 2024

Issue #

Description

  • use Swift 5.9 new API to create AsyncStream with contiuation, make code more predicatable

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.57%. Comparing base (4156bfb) to head (81e9a2f).
Report is 2 commits behind head on main.

Files Patch % Lines
...l-state-machine-swift/CancellableAsyncStream.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3710    +/-   ##
========================================
  Coverage   68.56%   68.57%            
========================================
  Files        1096     1089     -7     
  Lines       38119    37645   -474     
========================================
- Hits        26138    25814   -324     
+ Misses      11981    11831   -150     
Flag Coverage Δ
API_plugin_unit_test 68.97% <ø> (ø)
AWSPluginsCore 65.81% <ø> (ø)
Amplify 48.15% <100.00%> (-0.05%) ⬇️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.31% <83.33%> (-0.19%) ⬇️
CoreMLPredictions_plugin_unit_test ?
DataStore_plugin_unit_test 82.32% <ø> (-0.11%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (-1.50%) ⬇️
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.57% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d marked this pull request as ready for review May 17, 2024 21:01
@5d 5d requested a review from a team as a code owner May 17, 2024 21:01
@5d 5d merged commit b5f0dd5 into main May 21, 2024
79 checks passed
@5d 5d deleted the 5d/make-stream branch May 21, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants